Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cribs super recipe check #3608

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

lordIcocain
Copy link
Contributor

@lordIcocain lordIcocain commented Dec 6, 2024

Get pattern inputs
Find recipe in this machine recipe map
Save recipe in processingLogic using HashMap and slot.getHash() as key.
Machine recipe check will search for recipe in Map using slot.getHash() as key then performe recipeCheck for this single recipe.

Should improve endgame bases performance.

Performance test on my base by ordering 10 astral array

in 2.7.0
image

this
image

@chochem chochem added ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. labels Dec 6, 2024
@Dream-Master Dream-Master requested a review from a team December 7, 2024 21:51
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master
Copy link
Member

@lordIcocain can you run spotless

@lordIcocain
Copy link
Contributor Author

Done

Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the idea of this PR is good, though the implementation could use refinement

@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants