-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cribs super recipe check #3608
Open
lordIcocain
wants to merge
32
commits into
GTNewHorizons:master
Choose a base branch
from
lordIcocain:cribs_super_recipe_check
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cribs super recipe check #3608
lordIcocain
wants to merge
32
commits into
GTNewHorizons:master
from
lordIcocain:cribs_super_recipe_check
+162
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chochem
added
ongoing freeze - do not merge
PR tagged with this do not meet the requirement to be merged during a freeze.
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
labels
Dec 6, 2024
Dream-Master
removed
the
ongoing freeze - do not merge
PR tagged with this do not meet the requirement to be merged during a freeze.
label
Dec 8, 2024
…ribs_super_recipe_check
…ribs_super_recipe_check
@lordIcocain can you run spotless |
Done |
…ribs_super_recipe_check
serenibyss
reviewed
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the idea of this PR is good, though the implementation could use refinement
src/main/java/gregtech/api/metatileentity/implementations/MTEMultiBlockBase.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/IDualInputInventory.java
Outdated
Show resolved
Hide resolved
...main/java/gregtech/common/tileentities/machines/multi/compressor/MTEBlackHoleCompressor.java
Show resolved
Hide resolved
src/main/java/gregtech/common/tileentities/machines/multi/MTEMultiSolidifier.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🚧 Testing on Zeta
Do not merge yet, testing this PR on Zeta
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get pattern inputs
Find recipe in this machine recipe map
Save recipe in processingLogic using HashMap and slot.getHash() as key.
Machine recipe check will search for recipe in Map using slot.getHash() as key then performe recipeCheck for this single recipe.
Should improve endgame bases performance.
Performance test on my base by ordering 10 astral array
in 2.7.0
this